[Webkit-unassigned] [Bug 40515] Add a low-level platform abstraction for copy-and-paste and drag-and-drop data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40515


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58549|review?                     |review-
               Flag|                            |




--- Comment #12 from Darin Adler <darin at apple.com>  2010-06-29 15:05:07 PST ---
(From update of attachment 58549)
> +class ClipboardData : public RefCounted<ClipboardData> {

This seems fine, but I'm not sure why it's an abstract base class. Generally speaking the platform directory does not use runtime factories that vend objects of abstract base classes. I have seen other libraries that use this approach, but it has runtime costs that we prefer not to pay in WebKit.

The interface here looks generally OK in terms of what the functions are and the argument types, but the basic approach does not seem right.

An example of how we do this without virtual functions is in the FileChooser.h source file. Not sure that needs to be a reference-counted object, but otherwise it's a reasonable example. DragData.h is another example, although a particularly messy one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.