[Webkit-unassigned] [Bug 41238] RegExp performance slow on Dromaeo benchmark

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41238


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60039|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #11 from Darin Adler <darin at apple.com>  2010-06-29 11:40:53 PST ---
(From update of attachment 60039)
ChangeLog was mismerged here. This removed some change log entries. Because of that, I set commit-queue- on this patch.

> +        if (size1 == 0)
> +            return true;

One strange thing about WebKit style is that we write such this as:

    if (!size1)
        return true;

And the style bot is telling you about that.

> -            return s2.size() == size && memcmp(s1.data(), s2.data(), size * sizeof(UChar)) == 0;
> +            return memcmp(d1, d2, size1 * sizeof(UChar)) == 0;

The style bot has the same complaint on the existing code on this line (not something you added). I personally think memcmp is an exception. I find it easier to read calls to memcmp and strcmp if there is an "== 0" to mean "==" or "!= 0" to mean "!=" or even "< 0" to mean "<".

r=me as is if we fix the change log before committing, but you could consider using !size1 to make the style bot happy

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.