[Webkit-unassigned] [Bug 41348] Remove global variables from XSLTProcessorLibxslt.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41348


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |ap at webkit.org,
                   |                            |darin at apple.com
     Ever Confirmed|0                           |1




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org>  2010-06-29 10:05:34 PST ---
+        XSLStyleSheet* xslStyleSheet = (XSLStyleSheet*)style->doc->_private;

We use C++ style casts (such as static_cast), not C style ones. Some existing code in this file is wrong in this respect.

Does this change the mode of failure when another code in the same process uses libxslt? This can't be made to work as long as we have to use xsltSetLoaderFunc(), but can this make situation worse? I' worried that casting _private member set by other code may cause crashes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.