[Webkit-unassigned] [Bug 38256] [GTK] Random failure on 'testdownload' unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 29 08:19:25 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38256


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60024|                            |review?
               Flag|                            |




--- Comment #20 from Mario Sanchez Prada <msanchez at igalia.com>  2010-06-29 08:19:25 PST ---
Created an attachment (id=60024)
 --> (https://bugs.webkit.org/attachment.cgi?id=60024)
Make sure the set_filename function is called after handling the 'download-requested' signal for the asynchronous test

(In reply to comment #19)
> (In reply to comment #18)
> > > 
> > > Mmm, do you really need to dup the string?
> > 
> > As the string is gonna be used in a function called "on idle", I'd rather do it this way and then free the string there. I think it's safer.
> 
> AFAICT the string survives across the whole test, so whether it's used in an idle or not is irrelevant here.

Ok, you convinced me :-)

Here you have the new patch then

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list