[Webkit-unassigned] [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40278


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59221|0                           |1
        is obsolete|                            |
  Attachment #59773|0                           |1
        is obsolete|                            |
  Attachment #59773|commit-queue?               |
               Flag|                            |
  Attachment #60015|                            |review?, commit-queue?
               Flag|                            |




--- Comment #44 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-06-29 05:53:12 PST ---
Created an attachment (id=60015)
 --> (https://bugs.webkit.org/attachment.cgi?id=60015)
viewport-patch-for-eflwebkit-13

Hello Keneeth,

I told that you rejected this patch. Because, there are mixing zoom with scale.

   priv->settings.zoom_range.min_scale = ZOOM_MIN;
   priv->settings.zoom_range.max_scale = ZOOM_MAX;

However, there is no scale seprated from zooming in webkit-efl. As far as I know, webkit-efl can scale based on zoom.
Thus, this patch implements functionality of viewport meta tag using zoom.

In order to avoid this patch can make a confusion, I add comments for this issue as below,

   // Since there's no scale separated from zooming in webkit-efl, this functionality of
   // viewport meta tag is implemented using zoom.
   priv->settings.zoom_range.min_scale = ZOOM_MIN;
   priv->settings.zoom_range.max_scale = ZOOM_MAX;

If webkit-efl separate scale from zoom, I will also modify this patch based on the change.


Hello barbieri and lucas,

I would like to know your opinions as well.


Thank you,
Gyuyoung Kim

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.