[Webkit-unassigned] [Bug 37261] White space preceding a <br> affects layout of center or right aligned preceding line

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37261





--- Comment #21 from Xianzhu Wang <phnixwxz at gmail.com>  2010-06-29 00:43:19 PST ---
(In reply to comment #20)
> (From update of attachment 53511 [details])
> I'm skeptical about this patch.  It seems to be a big change for a somewhat theoretical problem.  Are there any web sites that render better with this change?  How many web sites render worse?  I'd like some estimate of the compatibility impact of this change before reviewing the code to technical correctness.

I just finished a test of 1000 popular web site home pages. 51 of them are affected by this problem. All of the affected pages will render better with the patch (though some differ slightly, some are very visible): center aligned texts will be better aligned; right aligned texts will be correctly aligned.

My testing criteria are: center aligned text, or right aligned ltr text, or left aligned rtl text; and computed value of 'white-space' style is 'normal'; and with spaces before <br>. (Left aligned ltr texts and right aligned rtl texts are not counted because space before <br> has no visual effect.)

This problem breaks the basic rule of HTML about spaces. It also affects editing because of the extra spaces before line breaks. I think this should be fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.