[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59890|review?                     |review+
               Flag|                            |




--- Comment #22 from Nikolas Zimmermann <zimmermann at kde.org>  2010-06-28 23:17:16 PST ---
(From update of attachment 59890)
WebCore/svg/SVGFEConvolveMatrixElement.cpp:117
 +      for (int i = 0; i < numberOfItems; i++)
I'd prefer ++i here, but hey :-)

WebCore/svg/SVGFEConvolveMatrixElement.cpp:145
 +          for (int i = 0; i < numberOfItems; i++)
Ditto.

WebCore/svg/SVGFEConvolveMatrixElement.cpp:148
 +              divisorValue = 1.0f;
= 1; No .0f postfixes (new style rule).

Please fix before landing! r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.