[Webkit-unassigned] [Bug 38775] rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38775





--- Comment #10 from MORITA Hajime <morrita at google.com>  2010-06-28 22:24:45 PST ---
Hi Victor, thank you for reviewing!
I updated the patch.

(In reply to comment #8)
> (From update of attachment 59887 [details])
> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:441
>  +              self._bogus_dir = os.path.join(parent_dir, "temp_svn_config")
> Should _bogus_dir be created for win?
Fixed. (I broke the code during copying...)

> 
> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:462
>  +              return self.run(['svn', 'diff', path])
> Missing "--config-dir"?
Fixed.

> 
> WebKitTools/Scripts/webkitpy/common/checkout/scm.py:467
>  +          return self.run(['svn', 'cat', path])
> Add "-r BASE" to svn cat?
Fixed, and added test for SVN.show_head()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.