[Webkit-unassigned] [Bug 41228] Fix http/tests/local/blob/send-data-blob.html on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41228





--- Comment #8 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-28 18:37:11 PST ---
(In reply to comment #5)
> (From update of attachment 59943 [details])
> WebCore/platform/BlobItem.cpp:128
>  +  // Convert line-endings (CR and LF) into CRLF.
> Probably better to say:
>   // Normalize all line-endings to CRLF.

Done.

> WebCore/platform/BlobItem.cpp:176
>  +  static CString convertToCR(const CString& from)
> I think we can combine convertToCR and convertToLF to one single function like the following:
>   convertToCROrLF(const CString& from, bool toCR)
>   {
>       char fromLineEndingChar = toCR ? '\n' : '\r';
>       char toLineEndingChar = toCR ? '\r' : '\n';
>       ...
>       while (...) {
>           ...
>           } else if (c == fromLineEndingChar) {
>               // Turn CF/LF into LF/CR.
>   }

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.