[Webkit-unassigned] [Bug 10313] xsl:import and document() don't work in stylesheets loaded via XMLHttpRequest
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 16:23:15 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=10313
--- Comment #62 from Alexey Proskuryakov <ap at webkit.org> 2010-06-28 16:23:14 PST ---
> I'm not sure I understand the problem you are describing here.
Document and DOMImplementation are tied to each other, so giving them both an origin document pointer is confusing.
There is no back link from DOMImplementation, so I'd say that it should be getting origin document pointer, but not Document.
> I have found a way to remove these global variables by using the _private
> field that exists on most libxml structs. My original plan was to submit
> a patch after my work on this bug was done, but maybe it should be included here?
I think that ideally, that would be done in a separate patch before this change.
> With Firefox 3.6.3 on Ubuntu I get these results.
Not matching Firefox is something we wouldn't generally want for the first iteration of this fix, now that we know how sensitive it is.
> So this means that the originDocument idea can be used, but it will only be used
> for xhr.responseXML to begin with?
Yes, let's try the simplest thing that will fix the original test case. And only for same origin case.
As for using the originDocument idea, yes, I don't think it's been shown wrong yet. But let's find out the answer to the below question first.
> > We'll still need to decide what to do with Referer header.
> What options are there?
First question - what does Firefox do? I can imagine several options for the Referer header:
- XMLHttpRequest request URL;
- XMLHttpRequest response URL (after redirects);
- taken from the document that created XMLHttpRequest;
- taken from the document that invoked XMLHttpRequest.responseXML;
- taken from the document that created XSLTProcessor;
- taken from the document that invoked XSLTProcessor.transformToDocument();
- no Referer sent at all.
We should investigate doing the same. If that proves too tricky, maybe it can wait until a follow-up patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list