[Webkit-unassigned] [Bug 41243] [chromium] Add support for WebGL to the accelerated compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41243





--- Comment #5 from Vangelis Kokkevis <vangelis at chromium.org>  2010-06-28 15:25:22 PST ---
(In reply to comment #3)
> (From update of attachment 59841 [details])
> WebKit/chromium/public/WebGraphicsContext3D.h:116
>  +      virtual unsigned int getPlatformTextureId() = 0;
> nit: "unsigned int" -> "unsigned" in webkit style

Done.

> 
> WebKit/chromium/src/GraphicsContext3D.cpp:363
>  +      if (!webContext->initialize(webAttributes, webView)) {
> instead of initializing a WebGraphicsContext3D with a WebView, we
> should instead ask the WebViewClient to create a WebGraphicsContext3D
> for us.  things that you request from a WebKitClient should not be
> WebView or WebFrame dependent.

If it's ok, I'd like to make this change in a separate CL. I've filed a bug for it:
https://bugs.webkit.org/show_bug.cgi?id=41315

> 
> looks fine otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.