[Webkit-unassigned] [Bug 41281] HTML5 Regression: Crash in insert()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41281


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59907|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2010-06-28 13:13:47 PST ---
(From update of attachment 59907)
I definitely like this change.

WebCore/html/HTMLDocumentParser.h:112
 +      bool shouldDelayEnd() const { return inWrite() || isWaitingForScripts() || inScriptExecution() || isScheduledForResume(); }
Seems sightly silly to put this in the header.  Generally the .cpp is better/cleaner.

I was sad when I broke write into insert and append because the code sharing previously seemed good.  It's still good.  But I wonder how it could be better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.