[Webkit-unassigned] [Bug 41014] [GTK] Add support for the progress tag
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 12:41:35 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41014
Xan Lopez <xan.lopez at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #59424|review? |review-
Flag| |
--- Comment #4 from Xan Lopez <xan.lopez at gmail.com> 2010-06-28 12:41:35 PST ---
(From update of attachment 59424)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>--- a/WebCore/platform/gtk/RenderThemeGtk.cpp
>+++ b/WebCore/platform/gtk/RenderThemeGtk.cpp
>@@ -34,6 +34,9 @@
> #include "MediaControlElements.h"
> #include "NotImplemented.h"
> #include "RenderBox.h"
>+#if ENABLE(PROGRESS_TAG)
>+#include "RenderProgress.h"
>+#endif
Style guide says this has to go at the end of the includes in its own block.
>+bool RenderThemeGtk::paintProgressBar(RenderObject* renderObject, const RenderObject::PaintInfo& paintInfo, const IntRect& rect)
>+{
>+ if (!renderObject->isProgress())
>+ return true;
>+
>+ GtkWidget* progressBarWidget = moz_gtk_get_progress_widget();
>+ if (!progressBarWidget)
>+ return true;
>+
>+ if (paintMozillaGtkWidget(this, MOZ_GTK_PROGRESSBAR, renderObject, paintInfo, rect))
>+ return true;
>+
>+ IntRect chunkRect(rect);
>+ RenderProgress* renderProgress = toRenderProgress(renderObject);
>+
>+ chunkRect.setHeight(chunkRect.height() - (2 * progressBarWidget->style->ythickness));
>+ chunkRect.setY(chunkRect.y() + progressBarWidget->style->ythickness);
>+ chunkRect.setWidth(chunkRect.width() - (2 * progressBarWidget->style->xthickness));
Don't access style like that, it won't compile with GSEAL enabled.
r- for the GSEAL stuff.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list