[Webkit-unassigned] [Bug 41244] [chromium]Remove deprecated code related to input method.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41244





--- Comment #8 from Jian Li <jianli at chromium.org>  2010-06-28 12:05:21 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 59910 [details] [details])
> > Do you want to have the reviewer to add your patch to the commit queue? If so, please set the commit-queue flag from empty to "?".
> > 
> > WebKit/chromium/ChangeLog:18
> >  +          * tests/PopupMenuTest.cpp:
> > Please also mention here why you need to change this file to override the default implementations since the main description only says to remove the deprecated code.
> 
> I should have made this change in the patch of bug 40608. These new methods are pure virtual, so they needs to be overridden here. But as this TestWebWidget class is not used anywhere, it's actually won't break any test without this change.

It would be better to mention all the changes made in the patch. It might be as simple as adding the following line to the description.
  Also update TestPopupMenuClient to add missing implementations.

Also, what I mean is that you need to set both review flag and commit-queue flag when you submit a new patch for review if you want to use the commit queue to commit your patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.