[Webkit-unassigned] [Bug 40985] gradient stroke on lines does not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40985


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #5 from Dirk Schulze <krit at webkit.org>  2010-06-28 11:19:55 PST ---
(In reply to comment #4)

> If you really want to be helpful you may try to clear your confusion in first place.

If you realy want to be helpful you shouldn't be so ignorant and search for the relevant parts in the Spec yourself to avoid confusions in the first line.

> 
> The section that deals with bounding box (SVG 1.1, 7.11) says:
> "Keyword objectBoundingBox should not be used when the geometry of the applicable element has no width or no height, such as the case of a horizontal or vertical line, even when the line has actual thickness when viewed due to having a non-zero stroke width since stroke width is ignored for bounding box calculations. When the geometry of the applicable element has no width or height and objectBoundingBox is specified, then the given effect (e.g., a gradient or a filter) will be ignored."
> 
> There is no rule in the latest SVG 1.1 specification which prohibits applying gradients specified with gradientUnits="userSpaceOnUse" to horizontal or vertical lines.

You're right, gradients should just be ignored on the use of objectBoundingBox and an width or height == 0. Thanks for pointing this out. The issue is in 
http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderSVGResource.cpp#L137
We should check somehow, if the SVGGradientElement/SVGPatternElement resource units or contentUnits work with objectBoundingBox. Isn't that difficult.
First we need to remove the isEmpty boundingBox check at this place. If strokePaintingResource is not 0, we have to check it's element (either SVGGradientElement or SVGPatternElement) for the unit spaces. And set strokePaintingResource back to 0 if one of the units is equal to objectBoundingBox and the boundingBox is empty (width or height == 0).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.