[Webkit-unassigned] [Bug 40932] Separate line-ending conversion code from BlobItem for code cleanup

Mon Jun 28 10:17:16 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40932

Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59273|review?                     |review-
               Flag|                            |

--- Comment #2 from Jian Li <jianli at chromium.org>  2010-06-28 10:17:16 PST ---
(From update of attachment 59273)
WebCore/platform/text/LineEnding.cpp:2
 +   * Copyright (C) 2010 Google Inc. All rights reserved.
Please check the author of the original function and give credit here too.

WebCore/platform/text/LineEnding.h:53
 +  // Convert WebCore::String to CString with given line-ending and encoding.
This comment is a little bit vague. It does not mention what is fixed regarding the line ending. Could you please add more detailed comment here?
Also mentioning "Convert WebCore::String to CString" seems to be unnecessary since the argument type and return type indicate that clearly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.