[Webkit-unassigned] [Bug 38924] Add a guarded window.timing binding.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38924





--- Comment #34 from Tony Gentilcore <tonyg at chromium.org>  2010-06-28 08:15:52 PST ---
(In reply to comment #33)
> (In reply to comment #32)
> > (In reply to comment #31)
> > > Looks like this turned on WebTiming support on windows:
> > > http://trac.webkit.org/changeset/61950/trunk/WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
> > > 
> > > Even though it's not implemented for JSC.  That seems like the error.
> 
> Steve fixed this in r61980.

Sorry for the breakage. Thank you for the fix and explanation!

> 
> > I failed to understand how that file works.
> 
> All ENABLE flags are listed in this file, whether turned on or off. Flags that are turned on look like this:
> 
> <UserMacro
>               Name="ENABLE_CHANNEL_MESSAGING"
>               Value="ENABLE_CHANNEL_MESSAGING"
>               PerformEnvironmentSet="true"
>       />
> 
> Flags that are turned off look like this:
> 
> <UserMacro
>               Name="ENABLE_BLOB_SLICE"
>               Value=""
>               PerformEnvironmentSet="true"
>       />
> 
> This is pretty similar to how FeatureDefines.xcconfig works.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.