[Webkit-unassigned] [Bug 41266] [Qt] dump bf history of child windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41266


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59862|review?                     |review+
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-28 06:42:11 PST ---
(From update of attachment 59862)
WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:804
 +          if (m_controller->shouldDumpBackForwardList()) {


WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +                fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData());
indentation seems wrong here, please fix before committing

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +                fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData());
I guess this would look less confusing, if you added the cast to a separate line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.