[Webkit-unassigned] [Bug 40835] Adds support for throwing behavior of SerializedScriptValue to be specified in the IDL.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40835





--- Comment #25 from Marcus Bulach <bulach at chromium.org>  2010-06-28 03:28:23 PST ---
thanks jeremy! all comments addressed, plus one clarification below. another look please?

(In reply to comment #22)
> (From update of attachment 59405 [details])
> WebCore/bindings/js/SerializedScriptValue.cpp:987
>  +      PassRefPtr<SerializedScriptValue> serializedValue = new SerializedScriptValue(SerializedScriptValueData::serialize(exec, value));
> RefPtr not PassRefPtr

Done.

> 
> WebCore/bindings/js/SerializedScriptValue.cpp:994
>  +      return serializedValue;
> .release() here.

Done.

> 
> WebCore/bindings/js/SerializedScriptValue.cpp:981
>  +      PassRefPtr<SerializedScriptValue> serializedValue = SerializedScriptValue::create(exec, value, &ec);
> Don't you need to set the dom exception here as well?
Not really, this is just calling the factory below (which sets dom exception).

> Also don't use PassRefPtr within a function.
Done.

> 
> WebCore/bindings/scripts/CodeGeneratorJS.pm:1719
>  +                                      push(@implContent, "    podImp = " . JSValueToNative($attribute->signature, "value", 0) . ";\n");
> Use booleans.
Done.

> 
> WebCore/bindings/scripts/CodeGeneratorJS.pm:1721
>  +                                      push(@implContent, "    podImp.set$implSetterFunctionName(" . JSValueToNative($attribute->signature, "value", 0) . ");\n");
> ditto (and elsewhere)
Done.


> 
> LayoutTests/storage/indexeddb/script-tests/idb-add-serialized-script-value.js:1
>  +  description("Test IndexedDB's openCursor.");
> Update the description.
ouch, done.

> 
> LayoutTests/storage/indexeddb/resources/shared.js:52
>  +      testFailed("Success function called unexpectedly: (" + event.code + ") " + event.message);
> There will be no code/message.
removed.

> 
> LayoutTests/fast/loader/stateobjects/initpopstateevent-expected.txt:5
>  +  PASS serialized script value threw an exception due to a cycle.
> Put a message in the beginning saying it'll print "COMPLETE" when done and then add code to do that.
done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.