[Webkit-unassigned] [Bug 41153] rebaseline-chromium-webkit-tests should add or remove files to local git repository
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jun 27 21:24:42 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41153
--- Comment #21 from Eric Seidel <eric at webkit.org> 2010-06-27 21:24:42 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
> > > WebKitTools/Scripts/webkitpy/common/checkout/scm.py:191: deprecated form of raising exception [pep8/W602] [5]
> > > Total errors found: 1 in 4 files
> > This is intentional. I prefer consistency around the neighboring code than PEP in this case.
>
> I'd just rewrite all lines which use this style in this module.
I totally agree. I think that should be a separate patch though. rs=me to do so, you don't even need to post it.
Caution, the reason why those are listed that way is to support pylint (which I'm not sure anyone has run in a while). I expect pylint can parse other syntaxes, but it will get confused if we move them all into a "throw notimplemented" call for example.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list