[Webkit-unassigned] [Bug 38929] Canvas: Ignore calls to drawImage() with non-finite parameters

Sun Jun 27 09:52:57 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38929

Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #8 from Andreas Kling <andreas.kling at nokia.com>  2010-06-27 09:52:57 PST ---
(In reply to comment #7)
> (From update of attachment 59852 [details])
> I read the section on drawImage in the WHATWG specification and I see nothing there that says a non-finite coordinate in an argument results in silently doing nothing. In some cases that may be correct, but in other cases it seems clear it is wrong.
> 
> For example it seems to me that if sx is infinite and all other values are finite then we should raise an INDEX_SIZE_ERR exception.
> 
> Am I missing something?

>From the 2D context section:

"Except where otherwise specified, for the 2D context interface, any method call with a numeric argument whose value is infinite or a NaN value must be ignored."

> If you don't like all this on one line there are two obvious things you can do...

I like the FloatRect::isFinite() idea, will add that in the next version of this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.