[Webkit-unassigned] [Bug 40781] Web Inspector: show actual breakpoint position in UI.

Sat Jun 26 04:25:22 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40781

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59770|review?                     |review-
               Flag|                            |

--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2010-06-26 04:25:22 PST ---
(From update of attachment 59770)
WebCore/bindings/js/ScriptDebugServer.cpp:140
 +  bool ScriptDebugServer::setBreakpoint(const String& sourceID, ScriptBreakpoint breakpoint, int lineNumber, int* actualLineNumber)
Given that you still prefer returning bool, you don't need to encode -1, so you should use unsigned values for line numbers.

WebCore/inspector/InspectorController.h:387
 +      HashMap<String, int> m_breakpointsMapping;
So why do you need this mapping after all? Why does sourceID:line not identify breakpoint properly?

Btw, if you really need unique breakpoint ids, now that setBreakpoint has a callback, you could assign them on backend (using progress counter) and send them back to the backend.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.