[Webkit-unassigned] [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40627


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59800|                            |review?
               Flag|                            |




--- Comment #27 from Joseph Pecoraro <joepeck at webkit.org>  2010-06-25 14:53:27 PST ---
Created an attachment (id=59800)
 --> (https://bugs.webkit.org/attachment.cgi?id=59800)
[PATCH] Part 4 - Client Notification when the Quota is Reached (needs part 3)


Client notifications. I ran into an issue with WebSecurityOrigin. WebSecurityOrigin is
used in a private interface (WebUIDelegatePrivate.h). It also has Database Quota
management baked in. And finally it uses (unsigned long long) types. The problems are:

  - (unsigned long long) makes sense for a quota, but they are stored in a SQLite DB as
    (long long) anyways. So, there is a downcast. I've changed the interface in
    WebSecurityOrigin to prevent any clients from providing too high a value, but
    Database's still have a potential downcast issue.

  - To not break the interface, I kept (WebSecurityOrigin*) as the type. And I give
    generic implementations of the quota management functions (usage, quota, setQuota)
    and instead rely on subclasses to handle it correctly. There are now Database
    and ApplicationCache subclasses which handle each of their respective quotas.

I think I'll stop here. Part 5 would be adding a test to make sure it all works, but
I don't want to go that far unless I've got an okay on some of the patches before!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.