[Webkit-unassigned] [Bug 41171] JSC bindings for Image Resizer API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 13:59:19 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41171


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59782|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #11 from David Levin <levin at chromium.org>  2010-06-25 13:59:19 PST ---
(From update of attachment 59782)
One more change that I can do on landing. 

I think I must have miscommunicated about what would be ideal here.

WebCore/html/AsyncImageResizer.cpp:73
 +          m_callbackInfo = 0;
I think this leaks the pointer that was in m_callbackInfo. The logic should be reversed in this area.

And the final if should be
if (m_callbackInfo) {
    resizeError();
    delete m_callbackInfo;
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list