[Webkit-unassigned] [Bug 41113] [WinCairo] Text box backgrounds do not render in partially opaque layers

Fri Jun 25 09:53:04 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41113

--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2010-06-25 09:53:04 PST ---
(In reply to comment #5)
> This doesn't seem correct. You are changing functionality (by fixing a bug). Can we come up with a test?

Thanks for looking at this patch. I agree after reading your comments that this does deserve a test. Given that the WinCairo port doesn't yet support pixel tests, do you have a suggestion for how best to test this change?

> Our style guidelines say that there should be braces around the body of the if (because it spans multiple lines, even though it's only a single statement).
> But I agree with Brent that a function might be clearer.

Alright, I should have an updated patch tonight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.