[Webkit-unassigned] [Bug 41188] Animations should not require from/to keyframes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41188


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59760|review?                     |review+
               Flag|                            |




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-06-25 07:54:28 PST ---
(From update of attachment 59760)
WebCore/css/CSSStyleSelector.cpp:1466
 +      if (initialListSize > 0 && (list.endKeyframes()-1)->key() != 1) {
Need spaces around the minus here.

LayoutTests/ChangeLog:8
 +          * animations/fill-mode-missing-from-to-keyframes-expected.txt: Added.
 +          * animations/fill-mode-missing-from-to-keyframes.html: Added.

Did you mean to include these?WebCore/css/CSSStyleSelector.h:115
 +          void generateKeyframeStyle(const RenderStyle*, const WebKitCSSKeyframeRule*, KeyframeList&);

This should be private.

Does this patch do the right thing if there's a transition running on the property that the animation is going to affect, and the 0% keyframe is missing?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.