[Webkit-unassigned] [Bug 40352] [Qt] instance objects created for QObjects are somtimes GC'd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40352





--- Comment #11 from Sam Magnuson <smagnuson at netflix.com>  2010-06-24 23:26:33 PST ---
(In reply to comment #9)
> In general however I think this patch looks good (I forgot to mention that earlier)

 (In reply to comment #8)
> (From update of attachment 59429 [details])
> WebCore/ChangeLog:13
>  +          No new tests. (OOPS!)
> If there are no new tests, then please remove this line.
> 
> However there are some tests for this code in WebKit/qt/tests/qwebframe (don't ask :). Could you add an auto-tests for this case there?
> 
> WebCore/bridge/qt/qt_instance.cpp:202
>  +          } else if ( m_object ) {
> Please remove the spaces around m_object.
> 
> WebCore/bridge/qt/qt_instance.cpp:212
>  +          if ( mark ) {
> Ditto.

Thanks for the feedback, I've added a test - and fixed the coding style issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.