[Webkit-unassigned] [Bug 39474] [GStreamer] GTK XOverlay support in GStreamerGWorld

Thu Jun 24 23:21:57 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39474

--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2010-06-24 23:21:57 PST ---
(In reply to comment #10)
> 
> I can't find what makes the m_fullscreenWindow go fullscreen (like a call to gtk_window_fullscreen), is this planned to be handled elsewhere? I also did not find who calls enterFullscreen, I think you're planning to land this first, and then wiring it up? I'd prefer to have the wiring up in this patch, otherwise we're landing dead code. I'll mark this r- so we can work on the issues I mentioned, thanks for working on this! =)

Thanks for the review.
I didn't include the "wiring" in this patch because it would have been to big. Like you guessed I plan to submit another patch including a FullscreenVideoController and the missing bits for enabling fullscreen video in the gtk+ port.

I'll send a new patch fixing the issues you spotted

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.