[Webkit-unassigned] [Bug 41171] JSC bindings for Image Resizer API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41171





--- Comment #4 from Sterling Swigart <sswigart at google.com>  2010-06-24 21:10:59 PST ---
Fixed. Notes:

> 
> WebCore/bindings/js/JSHTMLImageElementCustom.cpp:119
>  +          resizeOptions->setAspectRatioOption(preserveAspectRatio.toBoolean(exec));
> s/AspectRatioOption/PreserveAspectRatio/
> 

Like we spoke about, I retained the current naming.

> 
> 
> WebCore/html/AsyncImageResizer.cpp:61
>  +      m_callbackInfo = new CallbackInfo(this);
> Doesn't CallbackInfo and AsyncImageResizer leak if AsyncImageResizer::notifiyFinished never gets called?
> 

I now inherit from ActiveDOMObject. I made the object unsuspendable; is this okay? I couldn't determine from the code what exactly needed to be done (and why, mostly) to suspend AsyncImageResizer.

> WebCore/WebCore.vcproj/WebCore.vcproj:40199
>  +  
> There appear to be some extra changes here -- some blank lines added?
> 

For some reason the git diff command puts random newlines in the vcproj diff. They're not actually in my branch's vcproj file. Anyway, I deleted them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.