[Webkit-unassigned] [Bug 39472] [GStreamer] multiple video sink support

Thu Jun 24 06:49:19 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39472

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57337|review?                     |review+
               Flag|                            |

--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2010-06-24 06:49:19 PST ---
(From update of attachment 57337)
It looks very good to me. The only improvement I suggest is not creating member variables for the queue and the tee. They are completely useless - you are not even using them when enabling fullscreen, so just make them variables scoped to the createGSTPlayBin function, please, unless you have a good reason to keep them. I would prefer having more descriptive names for the queue and tee elements, too "t" does the job, but we can do better, I guess? =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.