[Webkit-unassigned] [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40278


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59221|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #34 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-24 06:28:54 PST ---
(From update of attachment 59221)
WebKit/efl/EWebLauncher/main.c:52
 +  #define ZOOM_MAX           1.0
Is it really good with default that does not allow zooming in the example app?
WebKit/efl/EWebLauncher/main.c:379
 +   * "viewport,changed" signal will be always emitted regardless of the viewport existence. 
viewport existence? Existence of the viewport meta tag?

WebKit/efl/ewk/ewk_view.cpp:115
 +          } zoom_range;
zoom_range contains min_scale etc? Shouldnt it be called scale_range instead?

WebKit/efl/ewk/ewk_view.cpp:591
 +      priv->settings.zoom_range.max_scale = ZOOM_MAX;
Same here... confusing that you mix scale and zoom.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.