[Webkit-unassigned] [Bug 39168] http://philip.html5.org/tests/canvas/suite/tests/2d.fillStyle.parse.system.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39168





--- Comment #7 from Philip Taylor <excors at gmail.com>  2010-06-24 04:21:06 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > The problem of this test case is actually because of ThreeDDarkShadow, which is not supported in WebKit. If changing it to some other named colors, the test case would work. I am wondering if Philip can make a change to the test case. :)
> 
> I doubt that he'll make a change, since the test checks what a browser is doing on setting an invalid string to fillStyle :-)

It's not testing invalid strings - it's testing that ThreeDDarkShadow is a valid colour keyword, and that it's not ignored when assigning to fillStyle (by testing that fillStyle doesn't remain as #FF0000 or #ff0000 or #f00 after the assignment).

(This would give an incorrect 'fail' if the browser decided that ThreeDDarkShadow should be a bright red colour, which would be legitimate for the browser but rather improbable.)

HTML5 just says it should be a CSS3 <color> value, which is defined in http://www.w3.org/TR/css3-color/#colorunits . No profile is specified, so I believe all the different <color> types must be supported, which includes the (deprecated) System Colors.

(I don't see this as a useful feature and I wouldn't care if the canvas spec was updated to exclude system colours, but for consistency with HTML and CSS it seems better to include them.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.