[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27551





--- Comment #49 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-06-23 18:35:10 PST ---
Attachment 59596 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
JavaScriptCore/runtime/JSCell.h:76:  Use 0 instead of NULL.  [readability/null] [4]
JavaScriptCore/runtime/JSCell.h:77:  Use 0 instead of NULL.  [readability/null] [4]
JavaScriptCore/wtf/FastMalloc.h:63:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/FastMalloc.h:97:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:98:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:99:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:100:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:101:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:102:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:103:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:104:  One space before end of line comments  [whitespace/comments] [5]
JavaScriptCore/wtf/FastMalloc.h:166:  One space before end of line comments  [whitespace/comments] [5]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/gtk/gtk2drawing.c"
JavaScriptCore/wtf/text/StringStatics.cpp:52:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:53:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:54:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:55:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:56:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:57:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
JavaScriptCore/wtf/text/StringStatics.cpp:58:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 19 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.