[Webkit-unassigned] [Bug 41106] [chromium] Allow composited layers to own their textures and specify how they get rendered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41106





--- Comment #4 from Vangelis Kokkevis <vangelis at chromium.org>  2010-06-23 18:05:41 PST ---
(In reply to comment #2)
> (From update of attachment 59570 [details])
> Looks good to me.  Just a couple nits:
> 
> WebCore/platform/graphics/chromium/LayerChromium.cpp:399
>  +  unsigned int WebGLLayerChromium::m_shaderProgramId = 0;
> nit: webkit style is to just use "unsigned" instead of "unsigned int"

Done. Also fixed all other instances of unsigned in the layer code.

> 
> WebCore/platform/graphics/chromium/LayerChromium.h:257
>  +  class ImageLayerChromium : public LayerChromium {
> style-nit: one class per file is the rule.  would you be okay splitting
> these out into their own files?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.