[Webkit-unassigned] [Bug 41106] [chromium] Allow composited layers to own their textures and specify how they get rendered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41106


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59570|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-23 16:24:51 PST ---
(From update of attachment 59570)
Looks good to me.  Just a couple nits:

WebCore/platform/graphics/chromium/LayerChromium.cpp:399
 +  unsigned int WebGLLayerChromium::m_shaderProgramId = 0;
nit: webkit style is to just use "unsigned" instead of "unsigned int"

WebCore/platform/graphics/chromium/LayerChromium.h:257
 +  class ImageLayerChromium : public LayerChromium {
style-nit: one class per file is the rule.  would you be okay splitting
these out into their own files?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.