[Webkit-unassigned] [Bug 41010] [chromium] Attach a GLES2Context to a WebView to enable resource sharing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41010





--- Comment #11 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-23 11:39:31 PST ---
(In reply to comment #9)
> > WebKit/chromium/src/WebViewImpl.cpp:2290
> >  +      if (!m_gles2Context) {
> > should we check if accelerated compositing is enabled before
> > creating the GLES2Context?
> 
> This method currently gets called from one of two places:
> 1. When creating a WebGL context, only if the accelerated compositing flag is 
enabled
> 2. When creating the page compositor
> 
> So, as it stands, it will only create the context if compositing is enabled.
However, one can imagine other cases where it would be useful to attach a GLES2 
context to the view even when not doing accelerated compositing so I don't think 
it should be checking whether the feature is enabled.
> I had previously made a mistake and defined the method within the 
USE(ACCELERATED_COMPOSTING) block which shouldn't be the case.  It's fixed in 
this patch.

OK.  My concern was with this being an API method, but your explanation
makes sense to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.