[Webkit-unassigned] [Bug 41010] [chromium] Attach a GLES2Context to a WebView to enable resource sharing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41010





--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-23 09:56:55 PST ---
(From update of attachment 59459)
WebKit/chromium/src/GLES2Context.cpp:68
 +      WebKit::WebViewImpl* webView = WebKit::WebViewImpl::fromPage(page);
I recommend putting a "using namespace WebKit" at the top of this file.

WebKit/chromium/src/WebViewImpl.h:340
 +      WebGLES2Context* GLES2Context();
WebKit style suggests that this method should be named gles2Context
instead.  See examples like ResourceRequest::httpReferrer.

WebKit/chromium/src/WebViewImpl.cpp:2290
 +      if (!m_gles2Context) {
should we check if accelerated compositing is enabled before
creating the GLES2Context?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.