[Webkit-unassigned] [Bug 40352] [Qt] instance objects created for QObjects are somtimes GC'd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40352


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59429|review?                     |review-
               Flag|                            |




--- Comment #8 from Simon Hausmann <hausmann at webkit.org>  2010-06-23 07:56:54 PST ---
(From update of attachment 59429)
WebCore/ChangeLog:13
 +          No new tests. (OOPS!)
If there are no new tests, then please remove this line.

However there are some tests for this code in WebKit/qt/tests/qwebframe (don't ask :). Could you add an auto-tests for this case there?

WebCore/bridge/qt/qt_instance.cpp:202
 +          } else if ( m_object ) {
Please remove the spaces around m_object.

WebCore/bridge/qt/qt_instance.cpp:212
 +          if ( mark ) {
Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.