[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861





--- Comment #16 from Zoltan Herczeg <zherczeg at webkit.org>  2010-06-23 02:17:26 PST ---
My notes:

Chromium ews incremental build feature needs fixed to detect new .idl files. I have opened a new bug report, and added a dependency for this patch (41011)

Most of the stlye bugs comes from the old patch, since the style was different at that time, and they are easy fixes.

> WebCore/svg/SVGFEConvolveMatrixElement.cpp:59
>  +          if (parseNumberOptionalNumber(value, x, y)) {
> What happens if parsing failed, you might want to reset order x/y then? Think of scripting feConvolveMatrix. We have other code like this, that handles the error case.

Other SVG elements do their parsing this way, so this is probably ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.