[Webkit-unassigned] [Bug 40724] Check for extra spacing on a variable declaration line.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40724





--- Comment #10 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-23 00:00:47 PST ---
(In reply to comment #9)
> Committed r61660: <http://trac.webkit.org/changeset/61660>

It looks like the test doesn't success with your last patch because you forgot to modify the test expectations after you addressed the following comment. It's a very good idea to run WebKitTools/Scripts/test-webkit-scripts before you upload your patch when you modify our scripts. Anyway, thanks again for your contribution!

> WebKitTools/Scripts/webkitpy/style/processors/cpp.py:1368
>  +                'Declaration has space between %s and %s ' % (matched.group('type'), matched.group('name')) )
> Having one space is OK so this sentence sounds a bit strange to me. Also, we don't need the trailing space.
> 
> So, I would say "Extra space between '%s' and '%s'" or something like this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.