[Webkit-unassigned] [Bug 40807] [EFL] add support for logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40807





--- Comment #8 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-06-22 20:33:47 PST ---
Hi Joone Hur,

Sorry taking long to reply, but I'm on a trip so quite busy and with restricted access to internet during the day.

The only observation is that I prefer "," instead of " " for separator for the same reasons Lucas said, particularly for consistency with Eina's log variable.

>From the EFL-port point-of-view I disagree with it and think we should go eina-log fully. But I'm not a reviewer and will not try to block your patch getting it if you find a reviewer to get your r+/cq+, I'm fine. I'd 

WebKit reviewers might correct me, but I'd do an AssertionsEfl.cpp that is linked instead of Assertions.cpp and it should implement WTFLogVerbose and friends using eina_log primitives directly. Another, bit worse solution, is to replace vprintf_stderr_common() implementation for EFL with eina_log_print(), as done for Windows, Symbian and others. However the output will not look as good as Eina will replicate the some formatting, it is better to feed function, line number, file name straight to Eina then everything works fine and matches what user (developer) would expect.

As added benefit of using Eina is that one might add different logging systems, like syslog, network log or even to serial to help debug in different scenarios.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.