[Webkit-unassigned] [Bug 36128] [Gtk] nameFromChildren is obsolete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36128


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58885|review?                     |review+
               Flag|                            |




--- Comment #18 from chris fleizach <cfleizach at apple.com>  2010-06-22 11:16:57 PST ---
(From update of attachment 58885)

> @@ -1501,8 +1493,8 @@ static AtkObject* webkit_accessible_table_get_caption(AtkTable* table)
>  static const gchar* webkit_accessible_table_get_column_description(AtkTable* table, gint column)
>  {
>      AtkObject* columnHeader = atk_table_get_column_header(table, column);
> -    if (columnHeader)
> -        return returnString(nameFromChildren(core(columnHeader)));
> +    if (columnHeader && ATK_IS_TEXT(columnHeader))
> +        return webkit_accessible_text_get_text(ATK_TEXT(columnHeader), 0, -1);
>  

> +    if (rowHeader && ATK_IS_TEXT(rowHeader))
> +        return webkit_accessible_text_get_text(ATK_TEXT(rowHeader), 0, -1);


Can ATK_IS_TEXT check for nil, so you don't need to check for nil and ATK_IS_TEXT?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.