[Webkit-unassigned] [Bug 40876] [EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40876





--- Comment #14 from Rafael Antognolli <antognolli at profusion.mobi>  2010-06-22 10:07:56 PST ---
(In reply to comment #13)
> I don't understand why style error happen. According to the url you let me know, they use to include <Ecore_Evas.h> without the macro as below,
> 
> 43    #include <Ecore.h>
> 44    #include <Ecore_Evas.h>
> 45    #include <Edje.h>
> 46    #include <Evas.h>
> 
> Do you know the reason ? Should do I use the macro for this?

Yes, you are right, you don't need the macro for this. But the problem now is the alphabetical order (as the Review Bot said). You should include Ecore_Evas.h just before <wtf/text/CString.h>, to keep it correct. Even the last header, Evas.h, is wrong, because it should be before <wtf/text/CString.h> as well.

For more information about this, check http://webkit.org/coding/coding-style.html, session #include Statements.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.