[Webkit-unassigned] [Bug 40854] JSC bindings for Image Resizer API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40854





--- Comment #9 from Sterling Swigart <sswigart at google.com>  2010-06-22 10:00:56 PST ---
(In reply to comment #5)
> (From update of attachment 59165 [details])
> I'm pretty sure you can create these bindings without any extra code.  If you have trouble, you should ask dumi.
> 

Done.

> WebCore/ChangeLog:59
>  +  2010-06-18  Sterling Swigart  <sswigart at google.com>
> You have two ChangeLogs in this patch.
> 

Fixed.

> WebCore/bindings/js/JSCustomImageResizerErrorCallback.cpp:47
>  +  JSCustomImageResizerErrorCallback::JSCustomImageResizerErrorCallback(JSObject* callback, JSDOMGlobalObject* globalObject)
> We should be able to auto-generate these callbacks now.  There are some examples in the database bindings.
> 

Done.

> WebCore/html/HTMLImageElement.idl:56
>  +          [Custom] void webkitGetImage(in DOMString mimeType, in ImageResizerSuccessCallback successCallback, [Optional] in ImageResizerErrorCallback errorCallback, [Optional] in ResizeOptions options)
> This shouldn't be custom.

I asked WPL about this, but I am still looking for further feedback on the current state of this patch.


@Dumitru:

- I consolidated the new CodeGeneratorJS.pm code.
- This patch is only for JSC bindings--when the V8 bindings are added, CodeGeneratorV8.pm will be changed to match.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.