[Webkit-unassigned] [Bug 40540] [chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40540


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59308|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #53 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-22 09:09:20 PST ---
(From update of attachment 59308)
WebCore/platform/chromium/ChromiumBridge.h:106
 +          static HashSet<String> clipboardReadTypes(PasteboardPrivate::ClipboardBuffer, bool* containsFilenames);
clipboardReadTypes might be better named clipboardGetAvailableTypes

WebKit/chromium/public/WebClipboard.h:57
 +          BufferDrag,
It is probably worth saying something about the meaning of BufferDrag here.
Mention that it is a readonly buffer corresponding to the last drag-n-drop
operation or something like that.
WebKit/chromium/public/WebClipboard.h:77
 +      virtual WebVector<WebString> readTypes(Buffer, bool* containsFilenames) = 0;
readTypes -> getAvailableTypes or maybe readAvailableTypes?  what does the
return value of readData indicate?  please specify.

WebKit/chromium/src/ChromiumBridge.cpp:203
 +      WebDragData dragData; // FIXME: Define the conversion from ClipboardData to WebDragData.
this would be a good place to call notImplemented()

WebKit/chromium/src/ChromiumBridge.cpp:221
 +      WebKit::WebString resultData;
no need for the WebKit:: prefix here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.