[Webkit-unassigned] [Bug 40964] New: JSC bindings for Image Resizer API (recreated due to commit-queue bug)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40964

           Summary: JSC bindings for Image Resizer API (recreated due to
                    commit-queue bug)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: sswigart at google.com


This patch exposes the classes and their callbacks to JSC through Image.webkitGetImage. The API is functionally incomplete, so it only will ever call the error callback or throw exceptions.

Recreated from 40854:

(In reply to comment #5)
> (From update of attachment 59165 [details])
> I'm pretty sure you can create these bindings without any extra code.  If you have trouble, you should ask dumi.
> 

Done.

> WebCore/ChangeLog:59
>  +  2010-06-18  Sterling Swigart  <sswigart at google.com>
> You have two ChangeLogs in this patch.
> 

Extras deleted, ChangeLogs recreated anyway.

> WebCore/bindings/js/JSCustomImageResizerErrorCallback.cpp:47
>  +  JSCustomImageResizerErrorCallback::JSCustomImageResizerErrorCallback(JSObject* callback, JSDOMGlobalObject* globalObject)
> We should be able to auto-generate these callbacks now.  There are some examples in the database bindings.
> 

Done; I changed CodeGenerator.pm to allow for this.

> WebCore/html/HTMLImageElement.idl:56
>  +          [Custom] void webkitGetImage(in DOMString mimeType, in ImageResizerSuccessCallback successCallback, [Optional] in ImageResizerErrorCallback errorCallback, [Optional] in ResizeOptions options)
> This shouldn't be custom.

This is currently in discussion, but I'm still looking for further feedback regarding this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.