[Webkit-unassigned] [Bug 40854] JSC bindings for Image Resizer API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40854





--- Comment #7 from Dumitru Daniliuc <dumi at chromium.org>  2010-06-21 18:39:52 PST ---
(From update of attachment 59321)
some drive-by comments:

WebCore/bindings/scripts/CodeGeneratorJS.pm:2182
 +                  push(@implContent, "    args.append(");
minor: it might be nicer to keep the code shorter by moving this line and the one after the if-block, inside the if-else block:
if (...)
  push(@implContent, "    args.append(jsString(exec, ${paramName}));\n");
else
  ...

or maybe even add a separate function for this? getToJSString()? i'll let adam decide what's best. :)

WebCore/bindings/scripts/CodeGeneratorJS.pm:2185
 +                   } else {
indentation is off by 1 space.

do we need to change the V8 code generator too? or toV8() works correctly on Strings?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.