[Webkit-unassigned] [Bug 38568] <input type=number> UI: Support disabled/readonly states

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38568


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55098|review?                     |review-
               Flag|                            |




--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-06-21 18:19:25 PST ---
(From update of attachment 55098)
Mostly questions and nits.

WebCore/rendering/TextControlInnerElements.cpp:244
 +      bool insideBox = local.x() >= 0 && local.x() < box->width() && local.y() >= 0 && local.y() < box->height();
Why this manual comparison instead of the contains() call you're replacing below?

WebCore/rendering/TextControlInnerElements.cpp: 
 +              if (local.y() < renderBox()->y() + renderBox()->height() / 2)
What happened to the renderBox()->y() part of this computation?

WebCore/rendering/TextControlInnerElements.h:81
 +      virtual bool isEnabledFormControl() const { return static_cast<Element*>(const_cast<SpinButtonElement*>(this)->shadowAncestorNode())->isEnabledFormControl(); }
const_cast?  We should be able to write this code without const_cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.