[Webkit-unassigned] [Bug 35350] DumpRenderTree should allow tests with modal dialogs

Mon Jun 21 18:00:09 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=35350

Prasad Tammana <prasadt at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59319|                            |review?
               Flag|                            |

--- Comment #24 from Prasad Tammana <prasadt at chromium.org>  2010-06-21 18:00:08 PST ---
Created an attachment (id=59319)
 --> (https://bugs.webkit.org/attachment.cgi?id=59319)
Patch to add a showModalDialog support for DumpRenderTree on Mac.

This patch is the same as previous one reviewed by Darin.  I've addressed a few non-mac platform specific issues identified by the build bots.  Specific changes are:

1) Updated some platform specific expected output files.  In some cases, deleted them where they are no longer different from the default ones.
2) sputnik tests pass on chromium as DRT on chromium has a default implementation for showModalDialog.
3) Fix a logic bug in window-function-name-getter-precedence.html and window-function-frame-getter-precedence.html to skip showModalDialog when its undefined.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.