[Webkit-unassigned] [Bug 40876] [EFL] Implement windowRect() and setWindowRect() in ChromeClientEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40876


Rafael Antognolli <antognolli at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |antognolli at profusion.mobi




--- Comment #8 from Rafael Antognolli <antognolli at profusion.mobi>  2010-06-21 14:53:30 PST ---
(In reply to comment #6)
> Created an attachment (id=59240)
 --> (https://bugs.webkit.org/attachment.cgi?id=59240) [details]
> patch for windowRect and setWindowRect
> 
> I modified this patch.

Hi Gyuyoung,

Do you have a good reason for using Ecore_X_Window instead of just Ecore_Evas? I think you could just get the window size as ecore_evas_geometry_get(). It would be more portable and give you the correct values anyway.

Of course, if Ecore_X_Window is necessary, you should put some #ifdef's as in http://trac.webkit.org/browser/trunk/WebCore/platform/efl/WidgetEfl.cpp#L209 (and the same for the header Ecore_X.h)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.